Fix the system-tag cli help default values #1219
Conversation
|
There is already a |
stats/system_tag.go
Outdated
| @@ -70,6 +71,17 @@ func (i *SystemTagSet) Map() TagSet { | |||
| return m | |||
| } | |||
|
|
|||
| // SetString is returns comma separeted list of the string representation of all values in the set | |||
There was a problem hiding this comment.
Typo in "is returns".
And also, should this method named List(), for alignment with Map() above? And actually return a slice instead.
There was a problem hiding this comment.
Fixed the typo and did some .. performance optimizations (not actually needed I am sure).
I don't think it's worth it to add a generic way to get a list of the set values from the SystemTags ... this is literally the only place where it's used ...
Codecov Report
@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
+ Coverage 73.75% 73.75% +<.01%
==========================================
Files 147 147
Lines 10675 10681 +6
==========================================
+ Hits 7873 7878 +5
- Misses 2343 2344 +1
Partials 459 459
Continue to review full report at Codecov.
|
stats/system_tag.go
Outdated
| @@ -70,6 +70,17 @@ func (i *SystemTagSet) Map() TagSet { | |||
| return m | |||
| } | |||
|
|
|||
| // SetString returns comma separeted list of the string representation of all values in the set | |||
mstoykov
changed the title
this was broken in #1148