Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable or relax settings for new golangci linters #1197

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Disable or relax settings for new golangci linters #1197

merged 1 commit into from
Oct 9, 2019

Conversation

na--
Copy link
Member

@na-- na-- commented Oct 9, 2019

@na-- na-- requested review from mstoykov, imiric and cuonglm October 9, 2019 14:11
cuonglm
cuonglm previously approved these changes Oct 9, 2019
View reviewed changes
@na-- na-- requested a review from cuonglm October 9, 2019 14:21
cuonglm
cuonglm previously approved these changes Oct 9, 2019
View reviewed changes
imiric
imiric reviewed Oct 9, 2019
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #1197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   73.67%   73.67%           
=======================================
  Files         145      145           
  Lines       10604    10604           
=======================================
  Hits         7812     7812           
  Misses       2333     2333           
  Partials      459      459

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 024b56a...4b1903e. Read the comment docs.

@na-- na-- requested review from cuonglm and imiric October 9, 2019 14:38
mstoykov
mstoykov approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

although I would prefer if in the future we drop the gocyclo and funlen exclude rules and instead either fix the tests or raise the limits for tests, But this can be done later on and will definitely involve a lot of changes to the tests

@na-- na-- merged commit 087f865 into master Oct 9, 2019
@na-- na-- deleted the linter-fixes branch October 9, 2019 14:56
@na-- na-- mentioned this pull request Oct 15, 2019
Closed
@mstoykov mstoykov added this to the v0.26.0 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiric imiric imiric approved these changes

@mstoykov mstoykov mstoykov approved these changes

@cuonglm cuonglm Awaiting requested review from cuonglm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging this pull request may close these issues.
5 participants
@na-- @codecov-io @mstoykov @imiric @cuonglm