-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use go1.13 for CI again #1177
Use go1.13 for CI again #1177
Conversation
go1.13.1 is out and fixed the http trace panic. Close #1153
Codecov Report
@@ Coverage Diff @@
## master #1177 +/- ##
==========================================
+ Coverage 73.59% 73.61% +0.01%
==========================================
Files 145 145
Lines 10575 10575
==========================================
+ Hits 7783 7785 +2
+ Misses 2333 2331 -2
Partials 459 459
Continue to review full report at Codecov.
|
Isn't go1.13.1 just a security fix release? The milestone seems to suggest this ... As far as I can see we need to wait for 1.13.2 |
Ah yes, my bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-aproving this, so it can be merged when 1.13.2 comes out
go1.13.3 is released with proper fixes, we can use go1.13 for CI now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I have the problem that because we don't specify the exact version of golang to be used, I can't now know if the package was updated and even if it's in dockerhub if it's not cached by circleci.
I just reran the test and it download 1.13.1 ... again ... so we wait :)
It should get the latest minor version of go1.13, IIRC. |
I recheck, circleci docker hub golang image is not updated, so we have to wait them upgrading. |
Yet another reason to get out of CircleCI (#959) - I see no reason why we should use some strange custom Go docker image and not the official ones... 😕 |
PR #1157 used go1.12 temporary for Dockerfile, to mitigate golang/go#34282. The backport issue was merged golang/go#34285 and
go1.13.1go1.13.3 is now released. so we can use go1.13 again.Close #1153