Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go1.13 for CI again #1177

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Use go1.13 for CI again #1177

merged 1 commit into from
Oct 22, 2019

Conversation

cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Sep 26, 2019

PR #1157 used go1.12 temporary for Dockerfile, to mitigate golang/go#34282. The backport issue was merged golang/go#34285 and go1.13.1 go1.13.3 is now released. so we can use go1.13 again.

Close #1153

go1.13.1 is out and fixed the http trace panic.

Close #1153
@cuonglm cuonglm requested review from mstoykov, imiric and na-- September 26, 2019 03:41
@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #1177 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
+ Coverage   73.59%   73.61%   +0.01%     
==========================================
  Files         145      145              
  Lines       10575    10575              
==========================================
+ Hits         7783     7785       +2     
+ Misses       2333     2331       -2     
  Partials      459      459
Impacted Files Coverage Δ
stats/cloud/collector.go 71.66% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c6796...ea08732. Read the comment docs.

@cuonglm cuonglm added this to the v0.26.0 milestone Sep 26, 2019
@mstoykov
Copy link
Contributor

Isn't go1.13.1 just a security fix release? The milestone seems to suggest this ... As far as I can see we need to wait for 1.13.2

@cuonglm
Copy link
Contributor Author

cuonglm commented Sep 26, 2019

Isn't go1.13.1 just a security fix release? The milestone seems to suggest this ... As far as I can see we need to wait for 1.13.2

Ah yes, my bad.

@cuonglm cuonglm changed the title Use go1.13 for CI again WIP: Use go1.13 for CI again Sep 26, 2019
@cuonglm cuonglm removed this from the v0.26.0 milestone Sep 26, 2019
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-aproving this, so it can be merged when 1.13.2 comes out

@cuonglm cuonglm changed the title WIP: Use go1.13 for CI again Use go1.13 for CI again Oct 18, 2019
@cuonglm cuonglm self-assigned this Oct 18, 2019
@cuonglm
Copy link
Contributor Author

cuonglm commented Oct 18, 2019

go1.13.3 is released with proper fixes, we can use go1.13 for CI now.

@cuonglm cuonglm requested review from mstoykov and imiric October 18, 2019 07:37
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I have the problem that because we don't specify the exact version of golang to be used, I can't now know if the package was updated and even if it's in dockerhub if it's not cached by circleci.
I just reran the test and it download 1.13.1 ... again ... so we wait :)

@cuonglm
Copy link
Contributor Author

cuonglm commented Oct 18, 2019

Again I have the problem that because we don't specify the exact version of golang to be used, I can't now know if the package was updated and even if it's in dockerhub if it's not cached by circleci.
I just reran the test and it download 1.13.1 ... again ... so we wait :)

It should get the latest minor version of go1.13, IIRC.

@cuonglm
Copy link
Contributor Author

cuonglm commented Oct 18, 2019

Again I have the problem that because we don't specify the exact version of golang to be used, I can't now know if the package was updated and even if it's in dockerhub if it's not cached by circleci.
I just reran the test and it download 1.13.1 ... again ... so we wait :)

It should get the latest minor version of go1.13, IIRC.

I recheck, circleci docker hub golang image is not updated, so we have to wait them upgrading.

@na--
Copy link
Member

na-- commented Oct 18, 2019

Yet another reason to get out of CircleCI (#959) - I see no reason why we should use some strange custom Go docker image and not the official ones... 😕

@cuonglm cuonglm requested a review from mstoykov October 21, 2019 17:20
@cuonglm
Copy link
Contributor Author

cuonglm commented Oct 21, 2019

@mstoykov @na-- circleci updated the golang image to 1.13.3.

@cuonglm cuonglm merged commit 90b62b3 into master Oct 22, 2019
@cuonglm cuonglm deleted the fix/issue-1153 branch October 22, 2019 06:32
@mstoykov mstoykov added this to the v0.26.0 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid memory address or nil pointer dereference when running in k8s
5 participants