-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Fix js exports issues #1099
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
- Coverage 73.26% 73.22% -0.04%
==========================================
Files 141 141
Lines 10251 10248 -3
==========================================
- Hits 7510 7504 -6
- Misses 2300 2302 +2
- Partials 441 442 +1
Continue to review full report at Codecov.
|
After way more testing and banging of my head against a figurative wall, I managed to find out why the second fix works :) : As is seen in that commit So that means that while during the execution of a module it sees it's When I changed it to instead have arguments to the function wrapper and provide the I suspect that the other fix works in some similar manner but also works around the fact that the main module's |
c1477b2
to
ebc684c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've mostly grokked the changes here and don't see any issues so far...
No description provided.