Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use http.Request's GetBody #1093

Merged
merged 2 commits into from
Aug 5, 2019
Merged

fix: use http.Request's GetBody #1093

merged 2 commits into from
Aug 5, 2019

Conversation

mstoykov
Copy link
Contributor

This is needed for correct handling of redirects of requests with bodies
and in http2 when the server sends GoAway without an error.

Unfortunately testing the GoAway case turned out to be problematic so it
is left for the future.

Fixes #1091

@mstoykov mstoykov requested a review from na-- July 30, 2019 10:58
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though don't merge it for now 😄

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #1093 into master will increase coverage by 0.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
+ Coverage    73.1%   73.12%   +0.01%     
==========================================
  Files         139      139              
  Lines       10223    10228       +5     
==========================================
+ Hits         7474     7479       +5     
  Misses       2308     2308              
  Partials      441      441
Impacted Files Coverage Δ
lib/netext/httpext/request.go 89.19% <92.85%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ac332...b2dd66d. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on the new master, and also add a line for this in the upcoming release notes?

This is needed for correct handling of redirects of requests with bodies
and in http2 when the server sends GoAway without an error.

Unfortunately testing the GoAway case turned out to be problematic so it
is left for the future.

Fixes #1091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoAway error on files POST requests
3 participants