Reuse the parsed core-js library across VUs #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
+ Coverage 72.67% 72.67% +<.01%
==========================================
Files 133 133
Lines 9843 9846 +3
==========================================
+ Hits 7153 7156 +3
Misses 2274 2274
Partials 416 416
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
+ Coverage 72.67% 72.67% +<.01%
==========================================
Files 133 133
Lines 9843 9846 +3
==========================================
+ Hits 7153 7156 +3
Misses 2274 2274
Partials 416 416
Continue to review full report at Codecov.
|
This was referenced Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches the
*goja.Programresult from parsing the core-js library so we can reuse it across VUs. Thanks to @matlockx for suggesting this, despite my attempts to misunderstand it 😊Brief performance comparisons on my laptop between this code and k6 v0.24.0 show an over 2x reduction of VU memory usage and initialization times when running the 2000 VU/empty script test from the StackOverflow question that started this whole investigation!