-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chocolatey gallery installation method #1027
Conversation
|
@majkinetor, thanks for making the chocolatey gallery package! Are you open to having the code for it be part of this repo? That way, we can make the package a first-class citizen and update it as soon as we release a new version. |
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 72.67% 72.69% +0.02%
==========================================
Files 133 133
Lines 9843 9843
==========================================
+ Hits 7153 7155 +2
+ Misses 2274 2273 -1
+ Partials 416 415 -1
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 72.67% 72.69% +0.02%
==========================================
Files 133 133
Lines 9843 9843
==========================================
+ Hits 7153 7155 +2
+ Misses 2274 2273 -1
+ Partials 416 415 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 72.67% 72.69% +0.02%
==========================================
Files 133 133
Lines 9843 9843
==========================================
+ Hits 7153 7155 +2
+ Misses 2274 2273 -1
+ Partials 416 415 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 72.67% 72.69% +0.02%
==========================================
Files 133 133
Lines 9843 9843
==========================================
+ Hits 7153 7155 +2
+ Misses 2274 2273 -1
+ Partials 416 415 -1
Continue to review full report at Codecov.
|
Automatic package requires non-trivial CI/CD infrastructure which is already setup on my repo. It follows your releases here with latency of less then a day. If it is to be here (as it should), this package doesn't need to be automatic but you still need to customize build with your choco account. Honestly, my packages just work (all versions, forever) so I guess there is no particular downside of package staying on my repo (except few hours latency and perceived safety but that is not much relevant). Think about it, if you decide to have it here, code needs to change and you need to update CircleCi deploy and do chocolatey related stuff. |
It seems like we forgot to close this when we mentioned the unofficial choco package in the docs: https://k6.io/docs/getting-started/installation/#windows This is the k6-docs issue where we can discuss further changes that might be needed: grafana/k6-docs#52 |
Readme updated