Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chocolatey gallery installation method #1027

Closed
wants to merge 1 commit into from

Conversation

majkinetor
Copy link

@majkinetor majkinetor commented May 20, 2019

Readme updated

@CLAassistant
Copy link

CLAassistant commented May 20, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@na--
Copy link
Member

na-- commented May 22, 2019

@majkinetor, thanks for making the chocolatey gallery package! Are you open to having the code for it be part of this repo? That way, we can make the package a first-class citizen and update it as soon as we release a new version.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #1027 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   72.67%   72.69%   +0.02%     
==========================================
  Files         133      133              
  Lines        9843     9843              
==========================================
+ Hits         7153     7155       +2     
+ Misses       2274     2273       -1     
+ Partials      416      415       -1
Impacted Files Coverage Δ
core/engine.go 93.92% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2999a1e...4da9831. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #1027 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   72.67%   72.69%   +0.02%     
==========================================
  Files         133      133              
  Lines        9843     9843              
==========================================
+ Hits         7153     7155       +2     
+ Misses       2274     2273       -1     
+ Partials      416      415       -1
Impacted Files Coverage Δ
core/engine.go 93.92% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2999a1e...4da9831. Read the comment docs.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #1027 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   72.67%   72.69%   +0.02%     
==========================================
  Files         133      133              
  Lines        9843     9843              
==========================================
+ Hits         7153     7155       +2     
+ Misses       2274     2273       -1     
+ Partials      416      415       -1
Impacted Files Coverage Δ
core/engine.go 93.92% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2999a1e...4da9831. Read the comment docs.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #1027 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   72.67%   72.69%   +0.02%     
==========================================
  Files         133      133              
  Lines        9843     9843              
==========================================
+ Hits         7153     7155       +2     
+ Misses       2274     2273       -1     
+ Partials      416      415       -1
Impacted Files Coverage Δ
core/engine.go 93.92% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2999a1e...4da9831. Read the comment docs.

@majkinetor
Copy link
Author

majkinetor commented May 22, 2019

Automatic package requires non-trivial CI/CD infrastructure which is already setup on my repo. It follows your releases here with latency of less then a day.

If it is to be here (as it should), this package doesn't need to be automatic but you still need to customize build with your choco account.

Honestly, my packages just work (all versions, forever) so I guess there is no particular downside of package staying on my repo (except few hours latency and perceived safety but that is not much relevant).

Think about it, if you decide to have it here, code needs to change and you need to update CircleCi deploy and do chocolatey related stuff.

@na--
Copy link
Member

na-- commented Mar 31, 2022

It seems like we forgot to close this when we mentioned the unofficial choco package in the docs: https://k6.io/docs/getting-started/installation/#windows

This is the k6-docs issue where we can discuss further changes that might be needed: grafana/k6-docs#52

@na-- na-- closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants