Correctly handle exportes when module.exports get's redefined #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in 3506ee1, but as this mostly happens in browserified code I didn't catch it as a problem. Now we get the "exports" once before we run the script - to be used to resolve import cycles, and once after the script is ran in order to get the exports if exports gets redifined in the script. This is probably broken in the case where both exports is redifined and there is an import cycle, but the fix for this seems to be some magic that will need to find out that we are actually requiring a new file and then to "reexport" the exports before the import? or something like that.
golangcibot
reviewed
May 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
==========================================
+ Coverage 72.33% 72.33% +<.01%
==========================================
Files 132 132
Lines 9717 9718 +1
==========================================
+ Hits 7029 7030 +1
Misses 2273 2273
Partials 415 415
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
==========================================
+ Coverage 72.33% 72.33% +<.01%
==========================================
Files 132 132
Lines 9717 9718 +1
==========================================
+ Hits 7029 7030 +1
Misses 2273 2273
Partials 415 415
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in 3506ee1, but as this mostly happens in browserified
code I didn't catch it as a problem. Now we get the "exports" once
before we run the script - to be used to resolve import cycles, and once
after the script is ran in order to get the exports if exports gets
redifined in the script.
This is probably broken in the case where both exports is redifined and
there is an import cycle, but the fix for this seems to be some magic
that will need to find out that we are actually requiring a new file and
then to "reexport" the exports before the import? or something like
that.