You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently use https://github.com/shibukawa/configdir to get the user level configuration folder (e.g. ~/.config/loadimpact/k6) in a cross-platform way. But it's a somewhat poor fit, and since it directly manipulates files via the os package, it's not compatible with https://github.com/spf13/afero and we can't use the majority of its functions directly in any testable way.
So as part of #935, I've mostly refactored it away, and we use it in only a single place to get the default location for the config.json file. So we can either replace it with something else, or we can easily write our own version in a few lines (basically, we only need to replicate globalSettingFolder from that library).
The text was updated successfully, but these errors were encountered:
We currently use https://github.com/shibukawa/configdir to get the user level configuration folder (e.g.
~/.config/loadimpact/k6
) in a cross-platform way. But it's a somewhat poor fit, and since it directly manipulates files via theos
package, it's not compatible with https://github.com/spf13/afero and we can't use the majority of its functions directly in any testable way.So as part of #935, I've mostly refactored it away, and we use it in only a single place to get the default location for the
config.json
file. So we can either replace it with something else, or we can easily write our own version in a few lines (basically, we only need to replicateglobalSettingFolder
from that library).The text was updated successfully, but these errors were encountered: