Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console shouldn't use os package directly #2565

Open
mstoykov opened this issue Jun 13, 2022 · 1 comment
Open

console shouldn't use os package directly #2565

mstoykov opened this issue Jun 13, 2022 · 1 comment
Labels
refactor

Comments

@mstoykov
Copy link
Contributor

js/console.go uses directly the os package while almost everything uses an abstraction such as afero

We should be using afero across everything (until #1079) so this needs to change.

This likely can be done similarly to #2487
@mstoykov mstoykov changed the title console uses os package directly console shouldn't use os package directly Jun 13, 2022
@mstoykov mstoykov mentioned this issue Jun 13, 2022
Merged
vanshaj added a commit to vanshaj/k6 that referenced this issue Jul 31, 2022
@vanshaj
grafana#2565: Removed os packages dependency on console and used afer…
f1a1ab8 
…o package
@vanshaj vanshaj mentioned this issue Jul 31, 2022
Closed
@na-- na-- added this to the v0.44.0 milestone Feb 1, 2023
@mstoykov mstoykov mentioned this issue Feb 1, 2023
Merged
@na-- na-- modified the milestones: v0.44.0, v0.45.0 Mar 29, 2023
@andrewslotin andrewslotin modified the milestones: v0.45.0, v0.46.0 May 31, 2023
@mstoykov mstoykov modified the milestones: v0.46.0, v0.47.0 Jul 31, 2023
@codebien codebien modified the milestones: v0.47.0, v0.48.0 Sep 25, 2023
@olegbespalov olegbespalov removed this from the v0.48.0 milestone Nov 16, 2023
@olegbespalov
Copy link
Contributor

For the record. After an internal discussion, we decided to clean a milestone since the issue was jumping between milestones without completion.

Once we determine which milestone it lands, we set the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2565: Removed os packages dependency on console and used afero package vanshaj/k6
5 participants
@andrewslotin @mstoykov @codebien @na-- @olegbespalov