-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cloud aggregation for different URLs with the same name tag #1166
Comments
Hmm we basically have 3 options:
If we choose option 3, and I'm not sure that's the best one, I feel like we shouldn't over-complicate it. While there are a bunch of complex and costly algorithms for string similarity/difference, in our case I'm not sure they would be needed, since we're dealing with URLs. So, I thing that can easily derive some sensible aggregated
The end result should be something like |
We discussed this in a call and the currently favored approach is none of the three I proposed above. Instead, for now (pending verification), we can just delete the So we can save some bandwidth if we don't send the @sniku, the only potential UX issue I see by removing the |
After some more internal discussions, we're back to the option of setting |
For cloud output, we currently don't aggregate HTTP metrics with different url tag, but with the same name tag. This PR improves aggregation by setting url tag to be the same as name tag. It's not ideal, but seems like the least bad option in term of UX. Fixes #1166
For cloud output, we currently don't aggregate HTTP metrics with different url tag, but with the same name tag. This PR improves aggregation by setting url tag to be the same as name tag. It's not ideal, but seems like the least bad option in term of UX. Fixes #1166
stats/cloud: improve cloud aggregation for different URLs For cloud output, we currently don't aggregate HTTP metrics with different url tag, but with the same name tag. This PR improves aggregation by setting url tag to be the same as name tag. It's not ideal, but seems like the least bad option in term of UX. Fixes #1166
We currently don't aggregate HTTP metrics with different
url
tags, but with the samename
tag. While that somewhat makes sense, it's counter-intuitive and doesn't follow the logic for URL grouping: https://docs.k6.io/docs/http-requests#section-url-groupingThe text was updated successfully, but these errors were encountered: