Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Go modules #1070

Closed
na-- opened this issue Jul 8, 2019 · 4 comments · Fixed by #1584
Closed

Adopt Go modules #1070

na-- opened this issue Jul 8, 2019 · 4 comments · Fixed by #1584

Comments

@na--
Copy link
Member

na-- commented Jul 8, 2019

After Go 1.13 comes out, likely sometime next month, we should probably replace dep with the official Go modules:

@wingyplus
Copy link
Contributor

I would like to help this issue if nobody working on it. :D

@cuonglm
Copy link
Contributor

cuonglm commented Sep 5, 2019

@wingyplus Thanks.

If you want to work on it, consider to update CI/CD, too.

@na--
Copy link
Member Author

na-- commented Sep 11, 2019

For posterity, it turns out that there are some serious deficiencies regarding vendoring support with Go modules that I didn't expect at all... I've collected a summary here: #1150 (comment)

@na-- na-- modified the milestones: v0.26.0, v0.27.0 Oct 10, 2019
@na--
Copy link
Member Author

na-- commented Nov 11, 2019

Something else we should adopt when we switch to Go modules: https://golang.org/pkg/runtime/debug/#ReadBuildInfo

Basically, it would be very useful to have the exact commit ID in each k6 binary, as part of k6 version and/or as a debug console message.

@imiric imiric modified the milestones: v0.27.0, v0.28.0 Jun 12, 2020
imiric pushed a commit that referenced this issue Aug 11, 2020
imiric pushed a commit that referenced this issue Aug 11, 2020
imiric pushed a commit that referenced this issue Aug 12, 2020
imiric pushed a commit that referenced this issue Aug 13, 2020
imiric pushed a commit that referenced this issue Aug 14, 2020
imiric pushed a commit that referenced this issue Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants