Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Oleg Bespalov <[email protected]>
  • Loading branch information
oleiade and olegbespalov authored Jul 24, 2024
1 parent 2b0bc1f commit fd6daac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions cmd/cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func (c *cmdCloud) run(cmd *cobra.Command, args []string) error {
}
if !cloudConfig.Token.Valid {
return errors.New( //nolint:golint
"not logged in, please login to the Grafana Cloud k6 " +
"not logged in, please login first to the Grafana Cloud k6 " +
"using the \"k6 cloud login\" command",
)
}
Expand Down Expand Up @@ -366,9 +366,9 @@ func getCmdCloud(gs *state.GlobalState) *cobra.Command {
cloudCmd := &cobra.Command{
Use: "cloud",
Short: "Run a test on the cloud",
Long: `Run a test archive in the Grafana Cloud k6.
Long: `Run a test in the Grafana Cloud k6.
This will execute the test in the Grafana Cloud k6 service. Be sure to run the "k6 cloud login" command prior to
This will archive test script(s), including all necessary resources, and execute the test in the Grafana Cloud k6 service. Be sure to run the "k6 cloud login" command prior to
authenticate with Grafana Cloud k6.`,
Args: exactCloudArgs(),
Deprecated: `the k6 team is in the process of modifying and deprecating the "k6 cloud" command behavior.
Expand Down
1 change: 1 addition & 0 deletions cmd/cloud_login.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ func (c *cmdCloudLogin) run(cmd *cobra.Command, _ []string) error {
newCloudConf.Token = token
default:
form := ui.Form{
Banner: "Please enter your Grafana Cloud k6 credentials",
Fields: []ui.Field{
ui.StringField{
Key: "Email",
Expand Down
2 changes: 1 addition & 1 deletion cmd/cloud_run.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func getCmdCloudRun(gs *state.GlobalState) *cobra.Command {
Short: "Run a test in Grafana Cloud k6",
Long: `Run a test in Grafana Cloud k6.
This will execute the test in the Grafana Cloud k6 service. Using this command requires to be authenticated
This will archive test script(s), including all necessary resources, and execute the test in the Grafana Cloud k6 service. Using this command requires to be authenticated
against Grafana Cloud k6. Use the "k6 cloud login" command to authenticate.`,
Example: exampleText,
Args: exactArgsWithMsg(1,
Expand Down

0 comments on commit fd6daac

Please sign in to comment.