Add reference to spec for GRPC -bin metadata

grafana · Aug 21, 2023 · c7c7ae6 · c7c7ae6
1 parent 8e049d2
commit c7c7ae6
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/js/modules/k6/grpc/client.go b/js/modules/k6/grpc/client.go
@@ -461,6 +461,8 @@ func (c *Client) parseInvokeParams(paramsVal goja.Value) (*invokeParams, error)
 				// TODO(rogchap): Should we manage a string slice?
 				strval, ok := kv.(string)
 				if !ok {
+					// The spec defines that Binary-valued keys end in -bin
+					//  https://grpc.io/docs/what-is-grpc/core-concepts/#metadata
 					if strings.HasSuffix(hk, "-bin") {
 						binval, ok := kv.([]byte)
 						if !ok {