Get rid of succ & fail marks on rate summary (#3765)

grafana · Sep 12, 2024 · 910eb0d · 910eb0d
1 parent 535a5bb
commit 910eb0d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/cmd/tests/cmd_run_test.go b/cmd/tests/cmd_run_test.go
@@ -616,7 +616,7 @@ func TestSetupTeardownThresholds(t *testing.T) {
 
 	stdOut := ts.Stdout.String()
 	t.Log(stdOut)
-	assert.Contains(t, stdOut, `✓ checks.........................: 100.00% ✓ 8`)
+	assert.Contains(t, stdOut, `✓ checks.........................: 100.00% 8 out of 8`)
 	assert.Contains(t, stdOut, `✓ http_reqs......................: 8`)
 	assert.Contains(t, stdOut, `✓ iterations.....................: 5`)
 	assert.Contains(t, stdOut, `✓ setup_teardown.................: 3`)

diff --git a/js/summary.js b/js/summary.js
@@ -233,8 +233,7 @@ function nonTrendMetricValueForSum(metric, timeUnit) {
     case 'rate':
       return [
         humanizeValue(metric.values.rate, metric, timeUnit),
-        succMark + ' ' + metric.values.passes,
-        failMark + ' ' + metric.values.fails,
+	      `${metric.values.passes} out of ${metric.values.passes + metric.values.fails}`,
       ]
     default:
       return ['[no data]']

diff --git a/js/summary_test.go b/js/summary_test.go
@@ -23,9 +23,9 @@ const (
 		"       ✓ check1\n" +
 		"       ✗ check3\n        ↳  66% — ✓ 10 / ✗ 5\n" +
 		"       ✗ check2\n        ↳  33% — ✓ 5 / ✗ 10\n\n" +
-		"   ✓ checks......: 75.00% ✓ 45  ✗ 15 \n"
+		"   ✓ checks......: 75.00% 45 out of 60\n"
 	countOut = "   ✗ http_reqs...: 3      3/s\n"
-	gaugeOut = "     vus.........: 1      min=1 max=1\n"
+	gaugeOut = "     vus.........: 1      min=1        max=1\n"
 	trendOut = "   ✗ my_trend....: avg=15ms min=10ms med=15ms max=20ms p(90)=19ms " +
 		"p(95)=19.5ms p(99.9)=19.99ms\n"
 )