Fix all loopclosure linter errors

grafana · Mar 31, 2023 · 4b30bf4 · 4b30bf4
1 parent c09919b
commit 4b30bf4
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 0 deletions.
diff --git a/api/v1/metric_test.go b/api/v1/metric_test.go
@@ -25,6 +25,7 @@ func TestNullMetricTypeJSON(t *testing.T) {
 		t.Parallel()
 
 		for mt, val := range values {
+			mt, val := mt, val
 			t.Run(val, func(t *testing.T) {
 				t.Parallel()
 
@@ -38,6 +39,7 @@ func TestNullMetricTypeJSON(t *testing.T) {
 		t.Parallel()
 
 		for mt, val := range values {
+			mt, val := mt, val
 			t.Run(val, func(t *testing.T) {
 				t.Parallel()
 
@@ -61,6 +63,7 @@ func TestNullValueTypeJSON(t *testing.T) {
 		t.Parallel()
 
 		for mt, val := range values {
+			mt, val := mt, val
 			t.Run(val, func(t *testing.T) {
 				t.Parallel()
 
@@ -74,6 +77,7 @@ func TestNullValueTypeJSON(t *testing.T) {
 		t.Parallel()
 
 		for mt, val := range values {
+			mt, val := mt, val
 			t.Run(val, func(t *testing.T) {
 				t.Parallel()
 

diff --git a/js/bundle_test.go b/js/bundle_test.go
@@ -368,6 +368,7 @@ func TestNewBundle(t *testing.T) {
 		t.Run("TLSCipherSuites", func(t *testing.T) {
 			t.Parallel()
 			for suiteName, suiteID := range lib.SupportedTLSCipherSuites {
+				suiteName, suiteID := suiteName, suiteID
 				t.Run(suiteName, func(t *testing.T) {
 					t.Parallel()
 					script := `
@@ -674,6 +675,7 @@ func TestOpen(t *testing.T) {
 	logger := testutils.NewLogger(t)
 
 	for name, fsInit := range fss {
+		name, fsInit := name, fsInit
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			for _, tCase := range testCases {

diff --git a/js/console_test.go b/js/console_test.go
@@ -322,13 +322,16 @@ func TestFileConsole(t *testing.T) {
 		preExistingText = "Prexisting file\n"
 	)
 	for name, level := range levels {
+		name, level := name, level
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			for args, result := range argsets {
+				args, result := args, result
 				t.Run(args, func(t *testing.T) {
 					t.Parallel()
 					// whether the file is existed before logging
 					for msg, deleteFile := range preExisting {
+						msg, deleteFile := msg, deleteFile
 						t.Run(msg, func(t *testing.T) {
 							t.Parallel()
 							f, err := ioutil.TempFile("", "")

diff --git a/metrics/thresholds_test.go b/metrics/thresholds_test.go
@@ -603,6 +603,7 @@ func TestThresholdsRunAll(t *testing.T) {
 	}
 
 	for name, data := range testdata {
+		name, data := name, data
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/output/influxdb/config_test.go b/output/influxdb/config_test.go
@@ -28,6 +28,7 @@ func TestParseURL(t *testing.T) {
 		"?payload_size=a":  {Config{}, "strconv.Atoi: parsing \"a\": invalid syntax"},
 	}
 	for str, data := range testdata {
+		str, data := str, data
 		t.Run(str, func(t *testing.T) {
 			t.Parallel()
 			config, err := ParseURL(str)