Skip to content

Commit

Permalink
Accept protoreflect deprecations and mark them as nolint
Browse files Browse the repository at this point in the history
  • Loading branch information
oleiade committed Nov 4, 2024
1 parent ce60bb0 commit 352fb7b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions js/modules/k6/grpc/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import (
"go.k6.io/k6/lib/netext/grpcext"

"github.com/grafana/sobek"
"github.com/jhump/protoreflect/desc"
"github.com/jhump/protoreflect/desc/protoparse"
"github.com/jhump/protoreflect/desc" //nolint:staticcheck // FIXME: #4035
"github.com/jhump/protoreflect/desc/protoparse" //nolint:staticcheck // FIXME: #4035
"google.golang.org/grpc"
"google.golang.org/grpc/credentials"
"google.golang.org/grpc/credentials/insecure"
Expand Down
2 changes: 1 addition & 1 deletion lib/netext/grpcext/conn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"io"
"testing"

"github.com/jhump/protoreflect/desc/protoparse"
"github.com/jhump/protoreflect/desc/protoparse" //nolint:staticcheck // FIXME: #4035
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"google.golang.org/grpc"
Expand Down
2 changes: 1 addition & 1 deletion lib/netext/grpcext/reflect.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"
"fmt"

"github.com/jhump/protoreflect/desc"
"github.com/jhump/protoreflect/desc" //nolint:staticcheck // FIXME: #4035
"github.com/jhump/protoreflect/grpcreflect"
"google.golang.org/grpc"
"google.golang.org/protobuf/types/descriptorpb"
Expand Down

0 comments on commit 352fb7b

Please sign in to comment.