-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update goja to prevent hangs around try/catch and Interrupts (#2600)
As explained in the [upstream PR](dop251/goja#405) previous to these changes, there was a way for Interrupt to basically be catched by a `try/catch`. This is still possible now, but it requiers that go code does actually clear the interrupt. It also clears the promise jobs if the whole execution gets interrupted which also would've been a problem, once we actually used them more. For more info see the [upstream changes and tests](dop251/goja@8795259)
- Loading branch information
Showing
5 changed files
with
19 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters