Use Empty message for NoOp request

grafana · Apr 21, 2022 · 187d336 · 187d336
1 parent d54954d
commit 187d336
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/netext/grpcext/conn_test.go b/lib/netext/grpcext/conn_test.go
@@ -57,7 +57,7 @@ func TestInvokeWithCallOptions(t *testing.T) {
 	c := Conn{raw: invokemock(reply)}
 	r := Request{
 		MethodDescriptor: methodFromProto("NoOp"),
-		Message:          []byte(`{"greeting":"text request"}`),
+		Message:          []byte(`{}`),
 	}
 	res, err := c.Invoke(context.Background(), "/hello.HelloService/NoOp", metadata.New(nil), r, grpc.UseCompressor("fakeone"))
 	require.NoError(t, err)
@@ -133,6 +133,14 @@ func TestConnInvokeInvalid(t *testing.T) {
 			req:    Request{MethodDescriptor: methodDesc},
 			experr: "message is required",
 		},
+		{
+			name:   "EmptyMessage",
+			ctx:    ctx,
+			url:    url,
+			md:     nil,
+			req:    Request{MethodDescriptor: methodDesc, Message: []byte{}},
+			experr: "message is required",
+		},
 	}
 
 	for _, tt := range tests {
@@ -261,7 +269,7 @@ package hello;
 
 service HelloService {
   rpc SayHello(HelloRequest) returns (HelloResponse);
-  rpc NoOp(HelloRequest) returns (Empty);
+  rpc NoOp(Empty) returns (Empty);
   rpc LotsOfReplies(HelloRequest) returns (stream HelloResponse);
   rpc LotsOfGreetings(stream HelloRequest) returns (HelloResponse);
   rpc BidiHello(stream HelloRequest) returns (stream HelloResponse);