Fixing values.yaml docs for schema generation, corrected values.schema.json

[julian-perge]

With 3.9.0, the values.schema.json is created incorrectly from the values.yaml, therefore not allowing any extra env values from manager.env to be placed in there since it's requiring an object, but env is supposed to be an array of objects.

Should fix #471

[CLAassistant]

All committers have signed the CLA.

[yorugac]

Hi @julian-perge, thanks for the PR.
According to the #471, there is probably a whole list of values that should be changed in the schema, if not all of them. If you'd like to work on that issue, #471, you're welcome to, but the schema overall should be fixed, not just a part of it.
Also, just in case, signing CLA is mandatory for this repo 🙂

[julian-perge]

Hi @julian-perge, thanks for the PR. According to the #471, there is probably a whole list of values that should be changed in the schema, if not all of them. If you'd like to work on that issue, #471, you're welcome to, but the schema overall should be fixed, not just a part of it. Also, just in case, signing CLA is mandatory for this repo 🙂

Thanks for the issue link, and I signed the CLA, but had my signing keys messed up. Should be fixed now.

Will probably work on improving the schema throughout the rest of the week when in down time.

[julian-perge]

@yorugac Updated PR to include the rest of the schema fixes.

[yorugac]

Hi @julian-perge, apologies for the delay! I've finally tested this: it seems that tolerations should also be changed to array - please see my comment below.
That's the only request from me: the rest seems to be working, AFAIS 🙌 Would you be able to update that part?

[yorugac]

Suggested change

	# type: object
	# type: array

I'm getting the following error now:

- tolerations: Invalid type. Expected: object, given: array

And tolerations are normally defined as an array:
https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/

[yorugac]

It appears this change request was done in a new PR by another contributor over here:
https://github.com/grafana/k6-operator/pull/481/files

[yorugac]

@julian-perge, I'll be merging your PR as is now, and merge the fix for tolerations from #481. I hope that's alright with you!

Thank you again, for fixing this 🙌