Adds support options.cloud #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorugac
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Thanks for the PR, @olegbespalov.
This change looks like it should be backwards compatible so I assume it would work with any version of k6.
There is a question about exact format: please see my comment.
Regarding the unit test: given the long deprecation period (years over here), yes, a small unit test(s) for the new logic would be nice.
olegbespalov
force-pushed
the
feat/options-cloud
branch
from
4277a10 to
de77470
Compare
yorugac
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Thanks for the update, @olegbespalov. The change seems to be working as expected 👍
ℹ️ Until new release, the full impact of this change is noticeable only with image: "grafana/k6:master".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change adds a new/actual way of defining cloud options (
options.cloud) to the k6-operator. A logic mimics the one in the k6-core; the prior is for defining cloud options with a fallback to the load impact.I haven't touched the README in that PR. It could be updated along with updates to the k6-docs (once we are confident to do that).
How did I test
TBH, I haven't done any testing apart from the running unit tests (
make test). I also quickly searched for any existing tests that could be adjusted by introducing a new logic. I could add a simple test case for the unit testing the fallback logic of the newTestNameandProjectIDfunctions if you think it's necessary or any other place that could be better for keeping those tests.Why?
The
options.cloudrefactor has been merged (grafana/k6#3348) into k6-core, and the new way of defining options could appear soon.Closes: #309