Core implementation for test runs in PLZ mode #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorugac
force-pushed
the
feat/add-plz-testruns
branch
2 times, most recently
from
4dc740c
to
9983f58
Compare
yorugac
force-pushed
the
feat/add-plz-testruns
branch
2 times, most recently
from
cbc9a61
to
757bd97
Compare
yorugac
force-pushed
the
feat/add-plz-testruns
branch
from
77b8250
to
837e325
Compare
yorugac
force-pushed
the
feat/add-plz-testruns
branch
from
837e325
to
2ec5788
Compare
yorugac
force-pushed
the
feat/add-plz-testruns
branch
from
2ec5788
to
d0530df
Compare
javaducky
reviewed
Jul 26, 2023
controllers/k6_controller.go
Outdated
|
|
||
| isAborted := status.Aborted() | ||
|
|
||
| // if isAborted { |
There was a problem hiding this comment.
Nit: remove commented code.
yorugac
force-pushed
the
feat/add-plz-testruns
branch
2 times, most recently
from
6ab0a1a
to
9ea5035
Compare
|
Branch updated and rebased with volumes as init container configuration as described in this comment. |
yorugac
force-pushed
the
feat/add-plz-testruns
branch
from
1924725
to
be149bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #236
This builds up on top of PR #238