-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async check util #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allansson
requested review from
mstoykov,
olegbespalov,
inancgumus and
ankur22
and removed request for
a team
August 13, 2024 09:09
This reverts commit 25b540d.
inancgumus
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉
ankur22
reviewed
Aug 14, 2024
going-confetti
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a version of the
check
function that makes working withasync
/await
more ergonomic. It is drop-in compatible with the existing check function, i.e. using only sync values won't wrap results in aPromise
. As an added bonus, it's also possible to skip passing the first value.Why
Writing clean code using the standard
check
function is hard when using async code. To check a value you need to declare a temporary variable and await the value first:This clutters the code with single use declarations and creates the need to make up bogus variable names.
Examples
EDIT: Removed the shorthand version because it wouldn't work with tags and having it as a drop-in replacement is more important.
Issue: grafana/jslib.k6.io#125