Update Webpack version #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
requested review from
oleiade and
olegbespalov
and removed request for
a team
olegbespalov
approved these changes
Jan 8, 2024
oleiade
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It updates the Webpack-related dependencies to their latest version:
webpackto5.89.0webpack-clito5.1.4Because (a) it's always good to keep dependencies updated, (b) they both have been there for some months for now, with no new updates, so I guess the risk is low, and (c) apparently each contributor has been using their own (globally installed) version of Webpack, so in some way the current version didn't have a very strong implication.
I've also modified the
webpackcommand (executed withnpm run webpack), to use the self-contained webpack version, instead of using it globally, which again shouldn't have big implications, but it's probably safer and more consistent.