Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support aws session token in sms and kms clients #87

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

jing-emma
Copy link
Contributor

This PR adds the support for aws session token in sms and kms clients to address the issue #85

@jing-emma jing-emma requested a review from a team as a code owner January 2, 2024 19:16
@jing-emma jing-emma requested review from codebien and joanlopez and removed request for a team January 2, 2024 19:16
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2024

CLA assistant check
All committers have signed the CLA.

@joanlopez joanlopez merged commit 38e71ff into grafana:main Jan 4, 2024
3 checks passed
@jing-emma
Copy link
Contributor Author

@joanlopez @codebien Thank you for reviewing and approving the PR. I saw the build pipeline succeeded. Does that mean the new version 0.11.1 was released? where do I find the released js files. I thought I could use https://jslib.k6.io/aws/0.11.1/ssm.js. But I got 404.

@joanlopez
Copy link
Contributor

joanlopez commented Jan 4, 2024

Does that mean the new version 0.11.1 was released? where do I find the released js files. I thought I could use https://jslib.k6.io/aws/0.11.1/ssm.js. But I got 404.

Ha! That's a very fair question, that we're just right now discussing and re-defining (see #89). The process of releasing a new version is described in the CONTRIBUTING guidelines, and requires some manual steps that end up with the addition of the new build into https://github.com/grafana/jslib.k6.io repository, and a deployment to make it available in jslib.k6.io. However, we haven't published a new release with your changes yet, and indeed we haven't do it for a few more changes already available in main.

I hope to get that discussion resolved, and hopefully sooner rather than later we'll publish a new release (either v0.11.1 or v0.12.0). But so far, I guess you should be able to directly point the raw files of the build, hosted in the repository (e.g. https://raw.githubusercontent.com/grafana/k6-jslib-aws/main/build/ssm.js), as per what's commented here.

Apologies for the inconveniences, hopefully sometime in the near future we'll automate this process.
Thanks for your comprehension, and again thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants