feat: [s3] implementation of api requests around s3 multipart upload #42
Conversation
|
|
| @@ -268,24 +268,180 @@ export class S3Client extends AWSClient { | |||
| this._handle_error('DeleteObject', res) | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
| ) | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
| return new S3Part(partNumber, res.headers['Etag']) | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
| this._handle_error('CompleteMultipartUpload', res) | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
|
こんにちは @ryoshindo、ご協力いただきありがとうございます 🙇🏻 This looks really good, I'll wait for @immavalls to take a look too if she has the time, 👍🏻 on my part, and ready to merge. Next steps on our side will be to put together a documentation PR for the k6 docs website, I'll probably add you as a reviewer there @ryoshindo if that's okay with you, so that you can confirm I documented the feature correctly. |
|
Thanks for the contribution @ryoshindo 🎉 |
|
@oleiade @immavalls ありがとうございます！ Thank you for the positive feedback! I'm glad you find the changes good. Please feel free to add me as a reviewer for the documentation PR on the k6 docs website, I'd be more than glad to help and confirm that the feature is documented correctly. Looking forward to the next steps! |
|
@ryoshindo, we are already working on the docs. If you have the time for a review, we would appreciate it. Docs in staging: https://mdr-ci.staging.k6.io/docs/refs/pull/1168/merge/javascript-api/jslib/aws/s3client/. It's not allowing me to add you as a reviewer there, not sure why 😢 cc: @oleiade |
Hello to the development team of k6-jslib-aws.
I regularly use k6 in my projects. Now, in the product I am planning to conduct a load test on, there is an AWS S3 Multipart Upload feature. In order to create a load testing scenario for this feature, I have implemented the Multipart Upload functionality in this PR. I would greatly appreciate it if you could review it.
Thank you in advance.