-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce more specific error kinds #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
requested review from
mstoykov and
joanlopez
and removed request for
a team
June 26, 2024 13:21
oleiade
requested review from
codebien
and removed request for
mstoykov and
joanlopez
June 27, 2024 06:45
Adding you specifically @codebien in this draft stage as we came up with that design together 🤝 If you get a chance to take a look, I'd much appreciate your input on this 🙇🏻 |
codebien
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
oleiade
force-pushed
the
error-types
branch
2 times, most recently
from
July 29, 2024 13:03
8f2f971
to
20fb397
Compare
oleiade
force-pushed
the
dependency_updates
branch
from
July 29, 2024 13:24
c6bf07b
to
f2b00ee
Compare
oleiade
changed the title
WIP introduce more specific error kinds
Introduce more specific error kinds
Jul 29, 2024
joanlopez
approved these changes
Jul 30, 2024
codebien
approved these changes
Jul 30, 2024
Co-authored-by: Ivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft addressing #100 (comment).
It introduces new error types for various error paths when using AWS client classes.