webcrypto: RSA support #1791
Merged
webcrypto: RSA support #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
requested review from
mstoykov and
joanlopez
and removed request for
a team and
heitortsergent
33 tasks
joanlopez
reviewed
Nov 4, 2024
docs/sources/k6/next/javascript-api/k6-experimental/webcrypto/rsahashedkeygenparams.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/javascript-api/k6-experimental/webcrypto/rsahashedkeygenparams.md
Outdated
Show resolved
Hide resolved
| name: "RSA-PSS", | ||
| modulusLength: 2048, | ||
| publicExponent: new Uint8Array([1, 0, 1]), | ||
| hash: { name: "SHA-256" }, |
There was a problem hiding this comment.
In the docs above, hash is typed as string, but here it looks like it is an object with the name attribute 🤔
There was a problem hiding this comment.
Should we add in the type definition something like: ... or object with a single name string property ({name: "SHA-256"})? Or it's just the example, that needs to be fixed? 🤔
There was a problem hiding this comment.
Good catch! It supports both, an object with name and a string
There was a problem hiding this comment.
Actually, since webcrypto docs has such "bug" since the beginning same as definitely typed 😢 I've fixed it here, but probably open the larger issue for fixing this in whole module
Co-authored-by: Joan López de la Franca Beltran <[email protected]>
olegbespalov
force-pushed
the
feat/webcrypto-rsa
branch
from
2fd5227 to
02ba83a
Compare
joanlopez
approved these changes
Nov 5, 2024
mstoykov
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This documents the latest changes to the webcrypto module that were done in https://github.com/grafana/xk6-webcrypto/releases/tag/v0.5.0
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.Related PR(s)/Issue(s)
grafana/k6#4025