Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code example errors #1681

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Fix code example errors #1681

merged 3 commits into from
Aug 5, 2024

Conversation

heitortsergent
Copy link
Collaborator

@heitortsergent heitortsergent commented Aug 1, 2024

What?

Fix a few code example errors and ESLint error messages.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

@heitortsergent
Copy link
Collaborator Author

I'm still getting the following ESLint errors, and I'm not sure how to fix it 😞.

✖ eslint -c ./docs/sources/.eslintrc.js --fix:

/Users/heitorts/Documents/GitHub/k6-docs/docs/sources/next/javascript-api/k6-browser/browsercontext/clearpermissions.md
  18:1  error  Parsing error: No Babel config file detected for /Users/heitorts/Documents/GitHub/k6-docs/docs/sources/next/javascript-api/k6-browser/browsercontext/clearpermissions.md/0_0.javascript. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

/Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/clearpermissions.md
  18:1  error  Parsing error: No Babel config file detected for /Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/clearpermissions.md/0_0.javascript. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

/Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/close.md
  20:1  error  Parsing error: No Babel config file detected for /Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/close.md/0_0.javascript. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

/Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/grantpermissions.md
  30:1  error  Parsing error: No Babel config file detected for /Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/grantpermissions.md/0_0.javascript. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

/Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/pages.md
  27:1  error  Parsing error: No Babel config file detected for /Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/pages.md/0_0.javascript. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

/Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/setgeolocation.md
  38:1  error  Parsing error: No Babel config file detected for /Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/browsercontext/setgeolocation.md/0_0.javascript. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

/Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/context.md
  24:1  error  Parsing error: No Babel config file detected for /Users/heitorts/Documents/GitHub/k6-docs/docs/sources/v0.97.x/javascript-api/k6-browser/context.md/0_0.javascript. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

@heitortsergent
Copy link
Collaborator Author

It looks like the files that ESLint was throwing the error were just missing async as part of the default function statement. :)

@heitortsergent heitortsergent marked this pull request as ready for review August 2, 2024 15:49
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for fixing this ❤️

@heitortsergent heitortsergent merged commit 937b25d into main Aug 5, 2024
5 checks passed
@heitortsergent heitortsergent deleted the hts/fix-code-examples branch August 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants