Document jslib-aws v0.12.1 #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
added
the
Area: OSS Content
This was referenced May 13, 2024
oleiade
force-pushed
the
jslib-aws/v0.12.0
branch
from
bf1f1ab
to
6a5df39
Compare
|
I've published jslib-aws v0.12.1 today, and updated the PR to reflect this change 👍🏻 |
|
Up 👀 @heitortsergent, can I get your eyes on this, please? The current documentation is outdated 🙂 |
heitortsergent
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Just some small nits, LGTM overall! Thanks for your patience @oleiade 🙇 .
docs/sources/next/javascript-api/jslib/aws/LambdaClient/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/jslib/aws/LambdaClient/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/jslib/aws/LambdaClient/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/jslib/aws/LambdaClient/invoke.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/jslib/aws/LambdaClient/invoke.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.51.x/javascript-api/jslib/aws/LambdaClient/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.51.x/javascript-api/jslib/aws/LambdaClient/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.51.x/javascript-api/jslib/aws/LambdaClient/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.51.x/javascript-api/jslib/aws/LambdaClient/invoke.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.51.x/javascript-api/jslib/aws/LambdaClient/invoke.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This Pull Request updates the jslib/aws documentation according to the changes made in v0.12.0 that we've just published.
Furthermore, I also went ahead and fixed the documentation and examples of the whole SignatureV4 API to address the recent undocumented changes we made to it.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.docs/sources/v{most_recent_release}folder of the documentation.Related PR(s)/Issue(s)
https://github.com/grafana/k6-jslib-aws/releases/tag/v0.12.0
grafana/k6-jslib-aws#102
grafana/k6-jslib-aws#103
grafana/k6-jslib-aws#67