Improve browser Touchscreen and tap
#1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
improve/browser-tap
branch
from
2320e94 to
931e541
Compare
inancgumus
force-pushed
the
improve/browser-tap
branch
from
931e541 to
4fcc688
Compare
Moves the example from page to the touchscreen.tap to prevent redundancy and improve maintainability of the docs
inancgumus
force-pushed
the
improve/browser-tap
branch
from
4fcc688 to
1b81abc
Compare
|
@heitortsergent @ankur22 Could you look at the current changes? I might apply the changes also to v0.51 after k6's release if the changes are OK. |
ankur22
approved these changes
May 7, 2024
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/tap.md
Outdated
Show resolved
Hide resolved
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve the async Tap documentation by adding the missing docs.
This might be merged after https://github.com/grafana/k6/releases/tag/v0.51.0. We need to apply the changes to version 0.51.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.docs/sources/v{most_recent_release}folder of the documentation.Related PR(s)/Issue(s)
Updates grafana/xk6-browser#1293