Removes experimental gRPC module docs #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
force-pushed
the
chore/clean-experimental-grpc
branch
from
85a2d92 to
1963033
Compare
olegbespalov
requested review from
a team,
mstoykov and
joanlopez
and removed request for
a team
olegbespalov
added
the
Area: OSS Content
25 tasks
mstoykov
approved these changes
Apr 30, 2024
codebien
approved these changes
May 2, 2024
heitortsergent
approved these changes
May 3, 2024
There was a problem hiding this comment.
Everything looks good, and all the aliases are working! Thanks for your patience @olegbespalov 🙇 .
|
@heitortsergent thanks! I'm going to merge this next week then 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the experimental gRPC module exertion's documentation. Since starting the k6 v0.51, we'll return an error if somebody tries to import that module.
This PR also sets the documentation aliases that redirect experimental-grpc URLs to k6-net-grpc module.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.Related PR(s)/Issue(s)
grafana/k6#3530