-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser M1/M2 Macs Docker steps #1437
Conversation
ebc8724
to
6aabffb
Compare
6aabffb
to
bdf8657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few minor comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple small comments but LGTM.
a233fd2
to
d2b2f1a
Compare
Co-authored-by: Marie Cruz <[email protected]>
d2b2f1a
to
04387eb
Compare
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
What?
Running browser tests
document as a 3rd optional step.Checklist
Please fill in this template:
make docs
command locally and verified that the changes look good.docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)
Closes: #1317