-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Custom Metrics / Performance Measure with Trend param isTime == true #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add isTime == true param to Trends
dirtydiesel46
changed the title
Update metrics.md
Update Custom Metrics / Performance Measure with Trend param isTime == true
Dec 2, 2023
Add isTime == true param to Trends
mdcruz
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Daniel! Just one minor comment :)
mdcruz
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ran the test locally, and I've updated the time from s
to ms
to reflect it accurately.
Co-authored-by: Marie Cruz <[email protected]>
Co-authored-by: Marie Cruz <[email protected]>
mdcruz
approved these changes
Dec 8, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add isTime == true param to Trends
Fixed value being added to the myTrend trend too
What?
Documentation shows
const myTrend = new Trend('total_action_time');
and not
const myTrend = new Trend('total_action_time',true);
Documentation shows
myTrend.add(total_action_time);
should be
myTrend.add(totalActionTime);
Documentation shows
and not
Checklist
Please fill in this template:
make docs
command locally and verified that the changes look good.Select one of these and delete the others:
If updating the documentation for the most recent release of k6:
If updating the documentation for the next release of k6:
docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)