-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate v0.48.0 release browser doc updates #1413
Conversation
27618bb
to
46d6448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to migrate these commits 🙌
For what I see, the format from previous version is maintained, so the only thing that I think we missed is some URLs to be updated to the new "version".
docs/sources/next/javascript-api/k6-experimental/browser/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/browsercontext/waitforevent.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/closecontext.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: ka3de <[email protected]>
- It removes the WIP tags and reformats the table markdown on the main browserContext page. - It removes the WIP notice, updates the description, updates the return value, and adds an example in the waitForEvent page.
Co-authored-by: ka3de <[email protected]>
048cbe8
to
fce579f
Compare
What
Migrating 3 commits from an old branch to the new way of working with doc updates.
Why
So that we don't lose the release changes coming up for v0.48.0.