-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update k6 browser documentation #1345
Conversation
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1345/merge It will be deleted automatically in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for working on this 🙇 I have some suggestions.
src/data/markdown/translated-guides/en/03 Using k6 browser/01 Overview.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
Co-authored-by: İnanç Gümüş <[email protected]>
Awesome, thank you! 💜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits, but LGTM!
For the screenshot issue (#1318), do we want to include more of a separate page or section, or do you think this is enough to close it?
src/data/markdown/translated-guides/en/03 Using k6 browser/01 Overview.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdcruz Should we change the base branch to update/browser-v1.1.0
? It's because the new docker feature hasn't been added yet.
Do you mean the removal of |
Ah, OK then 👍 Thanks for clarifying it 🙇
…On Thu, Sep 28, 2023 at 12:15 PM ka3de ***@***.***> wrote:
@mdcruz <https://github.com/mdcruz> Should we change the base branch to
update/browser-v1.1.0? It's because the new docker feature hasn't been
added yet.
Do you mean the removal of SYS_ADMIN capability as a requirement? I
believe it was already added, it's now released in the current docs version
here <https://k6.io/docs/using-k6-browser/running-browser-tests/>. Also
the current grafana/k6:master-with-browser image should include this
change, as I believe it's pushed to the registry through the CI so it does
not depend on the k6 release process.
—
Reply to this email directly, view it on GitHub
<#1345 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXVMAEK6JN4TJRKL3SPSLX4U53FANCNFSM6AAAAAA5JM7PPM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
I think, for now, this example is enough because we only have one section to cover how to run tests and the example script contains |
Updates k6 browser documentation based on a few issues: