Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update k6 browser documentation #1345

Merged
merged 4 commits into from
Sep 28, 2023
Merged

docs: update k6 browser documentation #1345

merged 4 commits into from
Sep 28, 2023

Conversation

mdcruz
Copy link
Contributor

@mdcruz mdcruz commented Sep 27, 2023

@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1345/merge

It will be deleted automatically in 30 days.

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for working on this 🙇 I have some suggestions.

Co-authored-by: İnanç Gümüş <[email protected]>
@mdcruz
Copy link
Contributor Author

mdcruz commented Sep 27, 2023

Great! Thanks for working on this 🙇 I have some suggestions.

Awesome, thank you! 💜

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, but LGTM!

For the screenshot issue (#1318), do we want to include more of a separate page or section, or do you think this is enough to close it?

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdcruz Should we change the base branch to update/browser-v1.1.0? It's because the new docker feature hasn't been added yet.

@ka3de
Copy link
Contributor

ka3de commented Sep 28, 2023

@mdcruz Should we change the base branch to update/browser-v1.1.0? It's because the new docker feature hasn't been added yet.

Do you mean the removal of SYS_ADMIN capability as a requirement? I believe it was already added, it's now released in the current docs version here. Also the current grafana/k6:master-with-browser image should include this change, as I believe it's pushed to the registry through the CI so it does not depend on the k6 release process.

@inancgumus
Copy link
Member

inancgumus commented Sep 28, 2023 via email

@mdcruz
Copy link
Contributor Author

mdcruz commented Sep 28, 2023

Some small nits, but LGTM!

For the screenshot issue (#1318), do we want to include more of a separate page or section, or do you think this is enough to close it?

I think, for now, this example is enough because we only have one section to cover how to run tests and the example script contains page.screenshot()

@mdcruz mdcruz merged commit dc6943c into main Sep 28, 2023
5 checks passed
@mdcruz mdcruz deleted the update-k6-browser-docs branch September 28, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants