Update methods on ElementHandle type to return Promises #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allansson
requested review from
mstoykov,
codebien,
oleiade,
olegbespalov,
nicolevanderhoeven,
ankur22,
inancgumus,
ka3de and
joanlopez
as code owners
allansson
removed request for
mstoykov,
oleiade,
codebien,
olegbespalov,
joanlopez,
ka3de and
nicolevanderhoeven
inancgumus
reviewed
Jun 5, 2024
|
|
||
| /** | ||
| * Fetch the element's attribute value. | ||
| * @param name Attribute name to get the value for. | ||
| * @returns Attribute value. | ||
| */ | ||
| getAttribute(name: string): string | null; | ||
| getAttribute(name: string): Promise<string | null>; |
There was a problem hiding this comment.
An update to return null is coming soon!
|
@allansson We can merge this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.