Use int64 as TypeID and use -1 as uninitialised value #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivachandran
force-pushed
the
use-int64-for-typeid
branch
from
7237405 to
905b8eb
Compare
sivachandran
changed the title
|
Thanks. I will take a look some time later . |
korniltsev
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JFR can have events with type
0. So the uninitialised value ofTypeIDcan't be0. To hold-1TypeIDtype is changed asint64.Also, the global type like
T_EXECUTION_SAMPLEand its bind variable needs to be uninitialised when the type metadata is not specified in the current chunk.I believe jfr-parse implementation is heavily inspired by https://github.com/async-profiler/. In async-profiler the global types are defined as
inthere. They are assigned with-1when the type metadata is not specified in the chunk here.