Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix registry configuration #156

Merged
merged 2 commits into from
Aug 14, 2024
Merged

chore: fix registry configuration #156

merged 2 commits into from
Aug 14, 2024

Conversation

npazosmendez
Copy link
Contributor

I misinterpreted this field, we should leave it blank to its default.

@github-actions GitHub Actions
Copy link
Contributor

Go coverage report (click to expand)
File %
github.com/grafana/influx2cortex/cmd/influx2cortex/main.go 0.0%
github.com/grafana/influx2cortex/pkg/influx/api.go 93.9%
github.com/grafana/influx2cortex/pkg/influx/errors.go 92.6%
github.com/grafana/influx2cortex/pkg/influx/parser.go 85.1%
github.com/grafana/influx2cortex/pkg/influx/proxy.go 64.6%
github.com/grafana/influx2cortex/pkg/influx/recorder.go 91.7%
github.com/grafana/influx2cortex/pkg/internalserver/service.go 0.0%
total 61.6%

fedetorres93
fedetorres93 approved these changes Aug 14, 2024
View reviewed changes
Copy link

@fedetorres93 fedetorres93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npazosmendez npazosmendez merged commit 63d141e into main Aug 14, 2024
9 checks passed
@npazosmendez npazosmendez deleted the njpm/fix-registry branch August 14, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carrieedwards carrieedwards carrieedwards approved these changes

@fedetorres93 fedetorres93 fedetorres93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npazosmendez @fedetorres93 @carrieedwards