[promtail] Implement config-reloader #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
config-reload
branch
from
63e7ea3
to
116ed7a
Compare
|
@zanhsieh Are you able to give feedback on this? |
|
Hi @zanhsieh no. This feature is opt-in. On update, without any changes to values.yaml. nothing would be changed on user side. |
zanhsieh
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
on large clusters, the rollout of promtail could take some time. This PR extends the current helm chart by an config reloader sidecar. It depends on grafana/loki#7247.
I used the config-reloader images from prometheus helm chart. config-reloader implements inotify to detect changes instantly.