StatPanel: Fixes hanging issue when all values are zero #29077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
a team,
mckn,
kaydelaney and
ryantxu
and removed request for
a team
torkelo
added
old backport v7.3.x
ryantxu
approved these changes
Nov 12, 2020
dprokop
approved these changes
Nov 13, 2020
grafanabot
pushed a commit
that referenced
this pull request
Nov 13, 2020
* StatPanel: Fixes hanging issue when all values are zero * Minor tweak (cherry picked from commit 01a4951)
torkelo
added a commit
that referenced
this pull request
Nov 13, 2020
) * StatPanel: Fixes hanging issue when all values are zero (#29077) * StatPanel: Fixes hanging issue when all values are zero * Minor tweak (cherry picked from commit 01a4951) * Fixed test Co-authored-by: Torkel Ödegaard <[email protected]> Co-authored-by: Torkel Ödegaard <[email protected]>
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
* StatPanel: Fixes hanging issue when all values are zero * Minor tweak
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
* StatPanel: Fixes hanging issue when all values are zero * Minor tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29073
Apperently Number.MIN_VALUE is not what I thought. Stupid rookie mistake :(
This PR #28982 that fixed min max calculations when one series had zero made it so that max became Number.MIN_VALUE when all values are zero as zero is actually smaller than Number.MIN_VALUE. This max value made bizcharts change the browser.
This changes the logic so min & max remain null if all values are null.