Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 728 sla graph over time #764

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Feature 728 sla graph over time #764

merged 2 commits into from
Jul 30, 2019

Conversation

JeferCatarina
Copy link
Contributor

@JeferCatarina JeferCatarina commented Jul 1, 2019 •
edited
Loading

PR related: #728

Added support to show IT Services graph over time and to apply "Functions" on it.

  • Interval between each SLA range: 86400s (1d);
  • When the time range is less than 1d it will return the exactly range specified;

image

image

@alexanderzobnin alexanderzobnin self-requested a review July 2, 2019 06:53
@alexanderzobnin alexanderzobnin self-assigned this Jul 2, 2019
@alexanderzobnin
Copy link
Collaborator

@JeferCatarina Thanks for the contribution! I think the same intervals as Zabbix provides makes sense. PR looks good overall, I need to do a more detailed review when I have time.

@alexanderzobnin alexanderzobnin added this to the 3.11 milestone Jul 2, 2019
@alexanderzobnin alexanderzobnin merged commit 2fac45c into grafana:master Jul 30, 2019
@alexanderzobnin alexanderzobnin modified the milestones: 3.11, 3.10.5 Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderzobnin alexanderzobnin Awaiting requested review from alexanderzobnin

Assignees

@alexanderzobnin alexanderzobnin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeferCatarina @alexanderzobnin