Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config page to follow best practices #1725

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Update config page to follow best practices #1725

merged 3 commits into from
Nov 8, 2023

Conversation

gwdawson
Copy link
Member

  • update the config page to match the best practices doc.
  • add @grafana/experimental package, components needed for best practices
  • custom Divider component to ensure backwards compatibility.

@gwdawson gwdawson self-assigned this Oct 25, 2023
@gwdawson gwdawson requested a review from a team as a code owner October 25, 2023 13:54
@gwdawson gwdawson requested review from gabor and zoltanbedi and removed request for a team October 25, 2023 13:54
@gwdawson gwdawson mentioned this pull request Oct 25, 2023
Closed
16 tasks
@gwdawson gwdawson requested a review from zoltanbedi November 1, 2023 09:55
zoltanbedi
zoltanbedi approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwdawson gwdawson merged commit 17d71f6 into master Nov 8, 2023
2 checks passed
@gwdawson gwdawson deleted the gareth/config-page-update branch November 8, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi zoltanbedi approved these changes

@gabor gabor Awaiting requested review from gabor gabor was automatically assigned from grafana/oss-big-tent

Assignees

@gwdawson gwdawson

Labels
None yet
Projects
OSS Big Tent
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwdawson @zoltanbedi