Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Triggers Panel by Event Tag #487

Closed
2 of 3 tasks
adrianmace opened this issue Nov 20, 2017 · 17 comments
Closed
2 of 3 tasks

Filter Triggers Panel by Event Tag #487

adrianmace opened this issue Nov 20, 2017 · 17 comments

Comments

@adrianmace
Copy link

adrianmace commented Nov 20, 2017

I'm submitting a ...

  • Bug report
  • Feature request
  • Question / Support request

I would like the ability to filter by Event Tags key/value on the Triggers Panel. I have two teams in my org using the Grafana panels and our triggers include the tag Team:Operations and Team:Support.

I would like to create a Triggers panel that only shows 'Support' tagged triggers for their dashboard, and another Triggers panel that shows 'Operations' tagged triggers for my dashboard.

Regards,

@alexanderzobnin
Copy link
Collaborator

Added Show tags option for panel.

screenshot from 2017-12-14 23-48-54

@alexanderzobnin
Copy link
Collaborator

screenshot from 2017-12-16 14-50-00

@alexanderzobnin
Copy link
Collaborator

alexanderzobnin commented Dec 16, 2017

Additional feature: click on the tag icon on the panel and this filter will be applied immediately and will appear in the Tags field.

@adrianmace
Copy link
Author

@alexanderzobnin it looks like you're using the tags from the trigger itself and not the event.. this means if the tag has a macro as it's value it's not being defined. Any chance this can be modified to pull the tags from the event specifically?

screen shot 2018-01-08 at 10 21 47 am

@alexanderzobnin
Copy link
Collaborator

@adrianmace yes, I use tags from trigger. I'll try to add event tags also, it isn't so hard.

@adrianmace
Copy link
Author

@alexanderzobnin thank you. Should I create a new issue or is no further action by me required.

I really do appreciate your work on this plugin it's been invaluable within our company :)

@alexanderzobnin
Copy link
Collaborator

@adrianmace no, I'm reopening this one.

@adrianmace
Copy link
Author

adrianmace commented Feb 27, 2018

hey mate, I hope you're doing well 😄 I didn't notice until recently that you work at Grafana Labs themselves 😮

I have just added a check mark to Bug Report as I feel that now that the feature is implemented, the macro values being undefined due to not being sourced from the event tags would be considered a bug. I hope that this allows you to re-label this ticket more accurately if required!

Feel free to change things around on this issue as you see fit 👍

@alexanderzobnin
Copy link
Collaborator

@adrianmace yes, I've been working in Grafana for about 1 year. Not sure about macro - it's tricky sometimes, because Zabbix API doesn't expand all macros at Zabbix side.

@alexanderzobnin alexanderzobnin modified the milestones: Grafana-Zabbix 3.9, Grafana-Zabbix 3.10 Mar 23, 2018
@rerime
Copy link

rerime commented May 29, 2018

@adrianmace
Copy link
Author

adrianmace commented May 29, 2018 via email

@rerime
Copy link

rerime commented May 30, 2018

@alexanderzobnin What do you think?

@adrianmace
Copy link
Author

adrianmace commented Jun 1, 2018

sorry it took a while to get to a PC.

FYI see tags param in the result json here: https://www.zabbix.com/documentation/3.4/manual/api/reference/problem/get

@alexanderzobnin
Copy link
Collaborator

Fixed, now tags are taking from the last event where macros are expanded.

@adrianmace
Copy link
Author

Thank you heaps! Will wait for the release.

@adrianmace
Copy link
Author

@alexanderzobnin Finally got a chance to apply the latest release. Tags are still coming through as the Macro :( Please see attached. https://imgur.com/xKqOyXg

@alexanderzobnin
Copy link
Collaborator

@adrianmace What kind of macro do you use? I see that it works for built-in macros. It may be a Zabbix issue (not all tags interpolated from the API). Please, try to add built-in tags and test it together.

Screenshot from 2019-04-18 18-42-25
Screenshot from 2019-04-18 18-42-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants