-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter Triggers Panel by Event Tag #487
Comments
Additional feature: click on the tag icon on the panel and this filter will be applied immediately and will appear in the Tags field. |
@alexanderzobnin it looks like you're using the tags from the trigger itself and not the event.. this means if the tag has a macro as it's value it's not being defined. Any chance this can be modified to pull the tags from the event specifically? |
@adrianmace yes, I use tags from trigger. I'll try to add event tags also, it isn't so hard. |
@alexanderzobnin thank you. Should I create a new issue or is no further action by me required. I really do appreciate your work on this plugin it's been invaluable within our company :) |
@adrianmace no, I'm reopening this one. |
hey mate, I hope you're doing well 😄 I didn't notice until recently that you work at Grafana Labs themselves 😮 I have just added a check mark to Bug Report as I feel that now that the feature is implemented, the macro values being undefined due to not being sourced from the event tags would be considered a bug. I hope that this allows you to re-label this ticket more accurately if required! Feel free to change things around on this issue as you see fit 👍 |
@adrianmace yes, I've been working in Grafana for about 1 year. Not sure about macro - it's tricky sometimes, because Zabbix API doesn't expand all macros at Zabbix side. |
It is not supported by api https://www.zabbix.com/documentation/3.4/manual/api/reference/trigger/get |
I would suggest looking at the problem.get API method. Each time a trigger
fires it creates a unique problem. This method will include the tag values
as defined for that particular instance of the trigger firing.
|
@alexanderzobnin What do you think? |
sorry it took a while to get to a PC. FYI see tags param in the result json here: https://www.zabbix.com/documentation/3.4/manual/api/reference/problem/get |
Fixed, now tags are taking from the last event where macros are expanded. |
Thank you heaps! Will wait for the release. |
@alexanderzobnin Finally got a chance to apply the latest release. Tags are still coming through as the Macro :( Please see attached. https://imgur.com/xKqOyXg |
@adrianmace What kind of macro do you use? I see that it works for built-in macros. It may be a Zabbix issue (not all tags interpolated from the API). Please, try to add built-in tags and test it together. |
I'm submitting a ...
I would like the ability to filter by Event Tags key/value on the Triggers Panel. I have two teams in my org using the Grafana panels and our triggers include the tag Team:Operations and Team:Support.
I would like to create a Triggers panel that only shows 'Support' tagged triggers for their dashboard, and another Triggers panel that shows 'Operations' tagged triggers for my dashboard.
Regards,
The text was updated successfully, but these errors were encountered: