filter triggers by acknowledged status, #141

grafana · Oct 24, 2017 · 611bd8b · 611bd8b
1 parent 2b5af92
commit 611bd8b
Show file tree

Hide file tree

Showing 16 changed files with 178 additions and 44 deletions.
diff --git a/dist/dashboards/zabbix_system_status.json b/dist/dashboards/zabbix_system_status.json
@@ -171,7 +171,6 @@
               "application": {
                 "filter": ""
               },
-              "countTriggers": false,
               "functions": [],
               "group": {
                 "filter": "/.*/"
@@ -182,11 +181,11 @@
               "item": {
                 "filter": ""
               },
-              "minSeverity": 0,
               "mode": 4,
-              "options": {
-                "countTriggers": false,
-                "showDisabledItems": false
+              "triggers": {
+                "count": false,
+                "minSeverity": 0,
+                "acknowledged": 2
               },
               "refId": "A",
               "target": ""
@@ -269,7 +268,6 @@
               "application": {
                 "filter": ""
               },
-              "countTriggers": true,
               "functions": [],
               "group": {
                 "filter": "$group"
@@ -280,10 +278,11 @@
               "item": {
                 "filter": ""
               },
-              "minSeverity": 3,
               "mode": 4,
-              "options": {
-                "showDisabledItems": false
+              "triggers": {
+                "count": true,
+                "minSeverity": 3,
+                "acknowledged": 2
               },
               "refId": "A",
               "target": ""

diff --git a/dist/datasource-zabbix/datasource.js b/dist/datasource-zabbix/datasource.js
diff --git a/dist/datasource-zabbix/datasource.js.map b/dist/datasource-zabbix/datasource.js.map
diff --git a/dist/datasource-zabbix/partials/query.editor.html b/dist/datasource-zabbix/partials/query.editor.html
@@ -123,14 +123,24 @@
       <div class="gf-form-select-wrapper width-16">
         <select class="gf-form-input"
               ng-change="ctrl.onTargetBlur()"
-              ng-model="ctrl.target.minSeverity"
+              ng-model="ctrl.target.triggers.minSeverity"
               ng-options="s.val as s.text for s in ctrl.triggerSeverity">
         </select>
       </div>
     </div>
+    <div class="gf-form max-width-20" ng-show="ctrl.target.mode == editorMode.TRIGGERS">
+      <label class="gf-form-label query-keyword width-8">Acknowledged</label>
+      <div class="gf-form-select-wrapper width-12">
+        <select class="gf-form-input"
+              ng-change="ctrl.onTargetBlur()"
+              ng-model="ctrl.target.triggers.acknowledged"
+              ng-options="a.value as a.text for a in ctrl.ackFilters">
+        </select>
+      </div>
+    </div>
 
     <gf-form-switch class="gf-form" label="Count" ng-show="ctrl.target.mode == editorMode.TRIGGERS"
-      checked="ctrl.target.countTriggers" on-change="ctrl.onTargetBlur()">
+      checked="ctrl.target.triggers.count" on-change="ctrl.onTargetBlur()">
     </gf-form-switch>
 
     <div class="gf-form gf-form--grow">

diff --git a/dist/datasource-zabbix/query.controller.js b/dist/datasource-zabbix/query.controller.js
diff --git a/dist/datasource-zabbix/query.controller.js.map b/dist/datasource-zabbix/query.controller.js.map
diff --git a/dist/datasource-zabbix/zabbixAPI.service.js b/dist/datasource-zabbix/zabbixAPI.service.js
diff --git a/dist/datasource-zabbix/zabbixAPI.service.js.map b/dist/datasource-zabbix/zabbixAPI.service.js.map
diff --git a/dist/test/datasource-zabbix/datasource.js b/dist/test/datasource-zabbix/datasource.js
@@ -457,7 +457,14 @@ var ZabbixAPIDatasource = function () {
         if (hosts.length) {
           var hostids = _lodash2.default.map(hosts, 'hostid');
           var appids = _lodash2.default.map(apps, 'applicationid');
-          return _this7.zabbix.getHostAlerts(hostids, appids, target.minSeverity, target.countTriggers, timeFrom, timeTo).then(function (triggers) {
+          var options = {
+            minSeverity: target.triggers.minSeverity,
+            acknowledged: target.triggers.acknowledged,
+            count: target.triggers.count,
+            timeFrom: timeFrom,
+            timeTo: timeTo
+          };
+          return _this7.zabbix.getHostAlerts(hostids, appids, options).then(function (triggers) {
             return _responseHandler2.default.handleTriggersResponse(triggers, timeRange);
           });
         } else {

diff --git a/dist/test/datasource-zabbix/query.controller.js b/dist/test/datasource-zabbix/query.controller.js
@@ -72,6 +72,8 @@ var ZabbixQueryController = exports.ZabbixQueryController = function (_QueryCtrl
 
     _this.slaPropertyList = [{ name: "Status", property: "status" }, { name: "SLA", property: "sla" }, { name: "OK time", property: "okTime" }, { name: "Problem time", property: "problemTime" }, { name: "Down time", property: "downtimeTime" }];
 
+    _this.ackFilters = [{ text: 'all triggers', value: 2 }, { text: 'unacknowledged', value: 0 }, { text: 'acknowledged', value: 1 }];
+
     _this.triggerSeverity = c.TRIGGER_SEVERITY;
 
     // Map functions for bs-typeahead
@@ -113,8 +115,11 @@ var ZabbixQueryController = exports.ZabbixQueryController = function (_QueryCtrl
         'application': { 'filter': "" },
         'item': { 'filter': "" },
         'functions': [],
-        'minSeverity': 3,
-        'countTriggers': true,
+        'triggers': {
+          'count': true,
+          'minSeverity': 3,
+          'acknowledged': 2
+        },
         'options': {
           'showDisabledItems': false
         }

diff --git a/dist/test/datasource-zabbix/zabbixAPI.service.js b/dist/test/datasource-zabbix/zabbixAPI.service.js
@@ -487,7 +487,13 @@ function ZabbixAPIServiceFactory(alertSrv, zabbixAPICoreService) {
       }
     }, {
       key: 'getHostAlerts',
-      value: function getHostAlerts(hostids, applicationids, minSeverity, count, timeFrom, timeTo) {
+      value: function getHostAlerts(hostids, applicationids, options) {
+        var minSeverity = options.minSeverity,
+            acknowledged = options.acknowledged,
+            count = options.count,
+            timeFrom = options.timeFrom,
+            timeTo = options.timeTo;
+
         var params = {
           output: 'extend',
           hostids: hostids,
@@ -503,7 +509,7 @@ function ZabbixAPIServiceFactory(alertSrv, zabbixAPICoreService) {
           selectHosts: ['host', 'name']
         };
 
-        if (count) {
+        if (count && acknowledged !== 0 && acknowledged !== 1) {
           params.countOutput = true;
         }
 
@@ -516,7 +522,15 @@ function ZabbixAPIServiceFactory(alertSrv, zabbixAPICoreService) {
           params.lastChangeTill = timeTo;
         }
 
-        return this.request('trigger.get', params);
+        return this.request('trigger.get', params).then(function (triggers) {
+          if (!count || acknowledged === 0 || acknowledged === 1) {
+            triggers = filterTriggersByAcknowledge(triggers, acknowledged);
+            if (count) {
+              triggers = triggers.length;
+            }
+          }
+          return triggers;
+        });
       }
     }]);
 
@@ -526,6 +540,20 @@ function ZabbixAPIServiceFactory(alertSrv, zabbixAPICoreService) {
   return ZabbixAPI;
 }
 
+function filterTriggersByAcknowledge(triggers, acknowledged) {
+  if (acknowledged === 0) {
+    return _lodash2.default.filter(triggers, function (trigger) {
+      return trigger.lastEvent.acknowledged === "0";
+    });
+  } else if (acknowledged === 1) {
+    return _lodash2.default.filter(triggers, function (trigger) {
+      return trigger.lastEvent.acknowledged === "1";
+    });
+  } else {
+    return triggers;
+  }
+}
+
 function isNotAuthorized(message) {
   return message === "Session terminated, re-login, please." || message === "Not authorised." || message === "Not authorized.";
 }

diff --git a/src/dashboards/zabbix_system_status.json b/src/dashboards/zabbix_system_status.json
@@ -171,7 +171,6 @@
               "application": {
                 "filter": ""
               },
-              "countTriggers": false,
               "functions": [],
               "group": {
                 "filter": "/.*/"
@@ -182,11 +181,11 @@
               "item": {
                 "filter": ""
               },
-              "minSeverity": 0,
               "mode": 4,
-              "options": {
-                "countTriggers": false,
-                "showDisabledItems": false
+              "triggers": {
+                "count": false,
+                "minSeverity": 0,
+                "acknowledged": 2
               },
               "refId": "A",
               "target": ""
@@ -269,7 +268,6 @@
               "application": {
                 "filter": ""
               },
-              "countTriggers": true,
               "functions": [],
               "group": {
                 "filter": "$group"
@@ -280,10 +278,11 @@
               "item": {
                 "filter": ""
               },
-              "minSeverity": 3,
               "mode": 4,
-              "options": {
-                "showDisabledItems": false
+              "triggers": {
+                "count": true,
+                "minSeverity": 3,
+                "acknowledged": 2
               },
               "refId": "A",
               "target": ""

diff --git a/src/datasource-zabbix/datasource.js b/src/datasource-zabbix/datasource.js
@@ -362,7 +362,14 @@ class ZabbixAPIDatasource {
       if (hosts.length) {
         let hostids = _.map(hosts, 'hostid');
         let appids = _.map(apps, 'applicationid');
-        return this.zabbix.getHostAlerts(hostids, appids, target.minSeverity, target.countTriggers, timeFrom, timeTo)
+        let options = {
+          minSeverity: target.triggers.minSeverity,
+          acknowledged: target.triggers.acknowledged,
+          count: target.triggers.count,
+          timeFrom: timeFrom,
+          timeTo: timeTo
+        };
+        return this.zabbix.getHostAlerts(hostids, appids, options)
         .then((triggers) => {
           return responseHandler.handleTriggersResponse(triggers, timeRange);
         });

diff --git a/src/datasource-zabbix/partials/query.editor.html b/src/datasource-zabbix/partials/query.editor.html
@@ -123,14 +123,24 @@
       <div class="gf-form-select-wrapper width-16">
         <select class="gf-form-input"
               ng-change="ctrl.onTargetBlur()"
-              ng-model="ctrl.target.minSeverity"
+              ng-model="ctrl.target.triggers.minSeverity"
               ng-options="s.val as s.text for s in ctrl.triggerSeverity">
         </select>
       </div>
     </div>
+    <div class="gf-form max-width-20" ng-show="ctrl.target.mode == editorMode.TRIGGERS">
+      <label class="gf-form-label query-keyword width-8">Acknowledged</label>
+      <div class="gf-form-select-wrapper width-12">
+        <select class="gf-form-input"
+              ng-change="ctrl.onTargetBlur()"
+              ng-model="ctrl.target.triggers.acknowledged"
+              ng-options="a.value as a.text for a in ctrl.ackFilters">
+        </select>
+      </div>
+    </div>
 
     <gf-form-switch class="gf-form" label="Count" ng-show="ctrl.target.mode == editorMode.TRIGGERS"
-      checked="ctrl.target.countTriggers" on-change="ctrl.onTargetBlur()">
+      checked="ctrl.target.triggers.count" on-change="ctrl.onTargetBlur()">
     </gf-form-switch>
 
     <div class="gf-form gf-form--grow">

diff --git a/src/datasource-zabbix/query.controller.js b/src/datasource-zabbix/query.controller.js
@@ -45,6 +45,12 @@ export class ZabbixQueryController extends QueryCtrl {
       {name: "Down time", property: "downtimeTime"}
     ];
 
+    this.ackFilters = [
+      {text: 'all triggers', value: 2},
+      {text: 'unacknowledged', value: 0},
+      {text: 'acknowledged', value: 1},
+    ];
+
     this.triggerSeverity = c.TRIGGER_SEVERITY;
 
     // Map functions for bs-typeahead
@@ -84,8 +90,11 @@ export class ZabbixQueryController extends QueryCtrl {
         'application': { 'filter': "" },
         'item': { 'filter': "" },
         'functions': [],
-        'minSeverity': 3,
-        'countTriggers': true,
+        'triggers': {
+          'count': true,
+          'minSeverity': 3,
+          'acknowledged': 2
+        },
         'options': {
           'showDisabledItems': false
         }