Skip to content

Commit

Permalink
Add $__range_series variable for calculating function over the whole …
Browse files Browse the repository at this point in the history
…series, #531
  • Loading branch information
alexanderzobnin committed Oct 9, 2019
1 parent ca50d0d commit 1827aa9
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 3 deletions.
2 changes: 2 additions & 0 deletions src/datasource-zabbix/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,5 @@ export const TRIGGER_SEVERITY = [

/** Minimum interval for SLA over time (1 hour) */
export const MIN_SLA_INTERVAL = 3600;

export const RANGE_VARIABLE_VALUE = 'range_series';
3 changes: 1 addition & 2 deletions src/datasource-zabbix/dataProcessor.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import _ from 'lodash';
import * as utils from './utils';
import ts from './timeseries';
import ts, { groupBy_perf as groupBy } from './timeseries';

let downsampleSeries = ts.downsample;
let groupBy = ts.groupBy_perf;
let groupBy_exported = (interval, groupFunc, datapoints) => groupBy(datapoints, interval, groupFunc);
let sumSeries = ts.sumSeries;
let delta = ts.delta;
Expand Down
3 changes: 3 additions & 0 deletions src/datasource-zabbix/datasource.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ export class ZabbixDatasource {
let timeFrom = Math.ceil(dateMath.parse(options.range.from) / 1000);
let timeTo = Math.ceil(dateMath.parse(options.range.to) / 1000);

// Add range variables
options.scopedVars = Object.assign({}, options.scopedVars, utils.getRangeScopedVars(options.range));

// Prevent changes of original object
let target = _.cloneDeep(t);

Expand Down
21 changes: 20 additions & 1 deletion src/datasource-zabbix/timeseries.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import _ from 'lodash';
import * as utils from './utils';
import * as c from './constants';

const POINT_VALUE = 0;
const POINT_TIMESTAMP = 1;
Expand Down Expand Up @@ -94,11 +95,15 @@ function groupBy(datapoints, interval, groupByCallback) {
}));
}

function groupBy_perf(datapoints, interval, groupByCallback) {
export function groupBy_perf(datapoints, interval, groupByCallback) {
if (datapoints.length === 0) {
return [];
}

if (interval === c.RANGE_VARIABLE_VALUE) {
return groupByRange(datapoints, groupByCallback);
}

let ms_interval = utils.parseInterval(interval);
let grouped_series = [];
let frame_values = [];
Expand Down Expand Up @@ -132,6 +137,19 @@ function groupBy_perf(datapoints, interval, groupByCallback) {
return grouped_series;
}

export function groupByRange(datapoints, groupByCallback) {
const frame_values = [];
const frame_start = datapoints[0][POINT_TIMESTAMP];
const frame_end = datapoints[datapoints.length - 1][POINT_TIMESTAMP];
let point;
for (let i=0; i < datapoints.length; i++) {
point = datapoints[i];
frame_values.push(point[POINT_VALUE]);
}
const frame_value = groupByCallback(frame_values);
return [ [frame_value, frame_start], [frame_value, frame_end] ];
}

/**
* Summarize set of time series into one.
* @param {datapoints[]} timeseries array of time series
Expand Down Expand Up @@ -495,6 +513,7 @@ const exportedFunctions = {
downsample,
groupBy,
groupBy_perf,
groupByRange,
sumSeries,
scale,
offset,
Expand Down
14 changes: 14 additions & 0 deletions src/datasource-zabbix/utils.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import _ from 'lodash';
import moment from 'moment';
import kbn from 'grafana/app/core/utils/kbn';
import * as c from './constants';

/**
* Expand Zabbix item name
Expand Down Expand Up @@ -141,6 +143,18 @@ export function isTemplateVariable(str, templateVariables) {
}
}

export function getRangeScopedVars(range) {
const msRange = range.to.diff(range.from);
const sRange = Math.round(msRange / 1000);
const regularRange = kbn.secondsToHms(msRange / 1000);
return {
__range_ms: { text: msRange, value: msRange },
__range_s: { text: sRange, value: sRange },
__range: { text: regularRange, value: regularRange },
__range_series: {text: c.RANGE_VARIABLE_VALUE, value: c.RANGE_VARIABLE_VALUE},
};
}

export function buildRegex(str) {
var matches = str.match(regexPattern);
var pattern = matches[1];
Expand Down

0 comments on commit 1827aa9

Please sign in to comment.