Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

update to latest es6-shim to fix type conflicts #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update to latest es6-shim to fix type conflicts #8

wants to merge 1 commit into from

Conversation

briangann
Copy link

this is to fix the bug in issue #7

latest typescript throws errors like this:

Using tsc v2.9.2
node_modules/grafana-sdk-mocks/app/headers/es6-shim/es6-shim.d.ts(12,5): error TS2687: All declarations of 'value' must have identical modifiers.
node_modules/grafana-sdk-mocks/app/headers/es6-shim/es6-shim.d.ts(607,5): error TS2717: Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'.

@briangann briangann requested a review from daniellee July 22, 2018 15:07
@ddimensia
Copy link

@daniellee Can this PR get some love so that we can use the latest typescript without relying on a fork.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daniellee daniellee Awaiting requested review from daniellee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briangann @ddimensia