build(deps): bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.45.0 to 0.46.0 #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
…golang.org/grpc/otelgrpc Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.45.0 to 0.46.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.45.0...zpages/v0.46.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
This was referenced Nov 13, 2023
andresmgot
reviewed
Nov 13, 2023
There was a problem hiding this comment.
@xnyo @marefr I believe these are the changes needed to update but I would need your eyes here.
Grafana will need changes to use this. Created a draft for that here: grafana/grafana#78069
backend/serve.go
Outdated
| @@ -85,11 +85,11 @@ func defaultGRPCMiddlewares(opts ServeOpts) []grpc.ServerOption { | |||
| grpcMiddlewares := []grpc.ServerOption{ | |||
| grpc.MaxRecvMsgSize(opts.GRPCSettings.MaxReceiveMsgSize), | |||
| grpc.StreamInterceptor(grpc_middleware.ChainStreamServer( | |||
| otelgrpc.StreamServerInterceptor(), | |||
| otelgrpc.StreamServerInterceptor(), //nolint:staticcheck | |||
There was a problem hiding this comment.
not sure what to do here. The library suggest to use NewServerHandler but that does not fit here.
There was a problem hiding this comment.
@andresmgot I pushed a fix to this PR's branch, please take a look: 1ed8e7b
I have also done the same for the draft PR in core: grafana/grafana@19843d8
This was referenced Nov 14, 2023
andresmgot
approved these changes
Nov 14, 2023
andresmgot
deleted the
dependabot/go_modules/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc-0.46.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.45.0 to 0.46.0.
Release notes
Sourced from go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc's releases.
... (truncated)
Changelog
Sourced from go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc's changelog.
Commits
b4b06bcRelease v1.21.0/v0.46.0/v0.15.0/v0.1.0 (#4546)c1ac303config: Prepare module for release (#4541)fe68fe9host: fix typo (#4540)016b46fotelgrpc: Use net.Listen in TestStatsHandler (#4538)23bd4edotelgrpc: Deprecate interceptors in favor of stats handlers (#4534)a3b16aeExpose instrumentation scope name (#4448)2b69029otelgrpc: Fix stats handlers to honor WithMessageEvents option (#4536)f6aeb0dotelgrpc: Stablize TestInterceptors (#4535)b44dfc9otelgrpc: Remove high cardinality metric attributes (#4322)2a5fe23otelgrpc: Refine tests to use a net socket instead of a buffer (#4503)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.