chore: bump go version to 1.22

[s4kh]

What this PR does / why we need it:
To allow otel dependency updates (which dropped support for Go 1.21)

Which issue(s) this PR fixes:

Fixes #1107
Fixes #1079

Special notes for your reviewer:
Updated grafana/grafana-plugin-examples#396 grafana/plugin-tools#1212

[CLAassistant]

All committers have signed the CLA.

[marefr]

Wonder what go version is used by grafana-plugin-ci in drone.yml (build) and whether we need to update that.

Always confused by where grafana/grafana-plugin-ci docker image are defined/pushed from. This is one of the benefits migrating from drone to github actions (that other issue) so maybe we can wait with updating drone and migrate to github actions after this is merged. WDYT?

[s4kh]

Wonder what go version is used by grafana-plugin-ci in drone.yml (build) and whether we need to update that.

Always confused by where grafana/grafana-plugin-ci docker image are defined/pushed from. This is one of the benefits migrating from drone to github actions (that other issue) so maybe we can wait with updating drone and migrate to github actions after this is merged. WDYT?

https://github.com/grafana/grafana-drone-extension/blob/main/images/grafana-plugin-ci/scripts/deploy.sh#L22 so the go version here is 1.21.3.

For migrating to GA using grafana/grafana-plugin-ci:1.9.5 is not required, right? Currently, I am iterating on this.

[andresmgot]

The approach sounds good to me, not sure why you are getting compilation errors

[marefr]

I think you can lint, build and test in the same job perhaps to simplify? Have you run go mod tidy after update of go.mod?

[s4kh]

@andresmgot @marefr
Apparently, when you wake up and try again, it works. Classic coding 🏛️

[s4kh]

implements #1079

[marefr]

implements #1079

Please add this to the PR description as Fixes #1079 so that it auto-close after this is merged

[s4kh]

@marefr, @xnyo Is there a webhook I need to disable continuous-integration/drone/pr?

[marefr]

Great work. Some minor things left

[xnyo]

@marefr, @xnyo Is there a webhook I need to disable continuous-integration/drone/pr?

@s4kh I think we just have to disable the repository in Drone: https://drone.grafana.net/grafana/grafana-plugin-sdk-go/settings

We have to do that after we merge this PR tho

[xnyo]

Awesome work! 🙌 👏 👏

Just a small nit, but LGTM otherwise

[marefr]

LGTM with a suggestion

[marefr]

@marefr, @xnyo Is there a webhook I need to disable continuous-integration/drone/pr?

@s4kh I think we just have to disable the repository in Drone: https://drone.grafana.net/grafana/grafana-plugin-sdk-go/settings

We have to do that after we merge this PR tho

I think we can remove it and make the new one required before merging this - let us know

[s4kh]

I think we can remove it and make the new one required before merging this - let us know

Do we set the required option in the GitHub settings? I'll disable the drone CI in https://drone.grafana.net/grafana/grafana-plugin-sdk-go/settings.

[marefr]

Is there a problem using one job for lint, build and test? Now it creates one check per job on the PR, would simplify to only have one job with multiple steps when configuring branch protection rules, e.g. which checks to be required

[s4kh]

It was recommended by the golangci-lint docs to use separate job - https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#how-to-use

[s4kh]

Though it works in the single job.

[marefr]

Hmm okay 🤔 Guess it depends on if you want to run lint in parallel with build/test vs all three synchronously. No strong opinions really, it was more convenient for having one required check and configuring the branch protection

[s4kh]

Merged into single job.

[s4kh]

Ready to rumble. ✔️

[s4kh]

@marefr for development have you configured golangci-lint on your machine and configured with your editor? I think it is better to lint errors(same lint config) in the editor and fix it before push.

[marefr]

LGTM I modified the branch protection rules