JSON: Ensure all fields types work as expected when they are the first field in a frame #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
commented
Sep 10, 2024
data/frame_json.go
Outdated
Comment on lines
455
to
475
| case FieldTypeInt64: | ||
| vals := newInt64Vector(0) | ||
| for iter.ReadArray() { | ||
| v := iter.ReadInt64() | ||
| vals.Append(v) | ||
| } | ||
| return vals, nil | ||
|
|
||
| case FieldTypeNullableInt64: | ||
| vals := newNullableInt64Vector(0) | ||
| for iter.ReadArray() { | ||
| t := iter.WhatIsNext() | ||
| if t == sdkjsoniter.NilValue { | ||
| iter.ReadNil() | ||
| vals.Append(nil) | ||
| } else { | ||
| v := iter.ReadInt64() | ||
| vals.Append(v) | ||
| } | ||
| } | ||
| return vals, nil |
There was a problem hiding this comment.
weirdly -- these are not necessary on my machine, but fail in CI without them 🤷🏻
ryantxu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the first field in values is read into a generic array and then converted to vector. This fails for JSON fields.
This PR fixes parsing JSON from the first field.